“Anyone have a track record with these longer than the year or so I’ve know about them?”
Yep, and the track record is excellent.
Your plumber used them correctly.
Like slip-joint connectors or compression fittings, however, they cannot be used in a concealed location.
Other wise they will be fine.
Pricier than other transition fittings from one type pipe to another, but fine.